Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Manage Autofill should be disabled when Autofill option is disabled #5146

Closed
srirambv opened this issue Oct 26, 2016 · 0 comments · Fixed by #5288
Closed

Manage Autofill should be disabled when Autofill option is disabled #5146

srirambv opened this issue Oct 26, 2016 · 0 comments · Fixed by #5288
Assignees
@darkdh
Labels
design A design change, especially one which needs input from the design team. feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.8dev

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
image

Expected behavior:
image

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All
  • Brave Version:
    0.12.7 Preview1
@srirambv srirambv added design A design change, especially one which needs input from the design team. feature/autofill labels Oct 26, 2016
@srirambv srirambv added this to the 0.12.8dev milestone Oct 26, 2016
@darkdh darkdh self-assigned this Oct 31, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 31, 2016
@darkdh
Disable autofill management button when autofill is disabled
e10a698 
fix brave#5146

Auditors: @bsclifton

Test Plan:
1. Go to about:preferences#security
2. Toggle "Enable Autofill" off
3. Manage Autofill Data button should be disabled
@darkdh darkdh mentioned this issue Oct 31, 2016
Merged
4 tasks
This was referenced Nov 2, 2016
Closed
Closed
Closed
This was referenced Nov 4, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
design A design change, especially one which needs input from the design team. feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

Disable autofill management button when autofill is disabled darkdh/browser-laptop
4 participants
@alexwykoff @luixxiul @darkdh @srirambv