Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Selected bookmark items don't clear selection when clicked outside the view #5223

Closed
srirambv opened this issue Oct 28, 2016 · 2 comments · Fixed by #5331
Closed

Selected bookmark items don't clear selection when clicked outside the view #5223

srirambv opened this issue Oct 28, 2016 · 2 comments · Fixed by #5331
Assignees
@bsclifton
Labels
feature/bookmarks feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.8dev

Comments

@srirambv
Copy link
Collaborator

srirambv commented Oct 28, 2016 •
edited by bsclifton
Loading

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Selected bookmark items doesn't clear selection when clicked outside the view

Expected behavior:
Should clear selection when clicked outside the view

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.7 RC2 (Same on 0.12.6)
  • Steps to reproduce:
    1. Ensure you have history entries/ multiple bookmarks
    2. Select multiple bookmarks/history entries using Ctrl/Shift
    3. Click outside the entries, selected items doesn't get cleared, Have to click on an entry to clear the multiple selection
  • Screenshot if needed:
    multiuncheck
  • Any related issues:
    cc: @bsclifton
    @alexwykoff /@luixxiul To verify for same behavior on MAC
@srirambv srirambv added this to the 0.12.8dev milestone Oct 28, 2016
@bsclifton bsclifton self-assigned this Nov 1, 2016
@bsclifton bsclifton mentioned this issue Nov 1, 2016
Merged
4 tasks
bbondy pushed a commit that referenced this issue Nov 2, 2016
@bsclifton @bbondy
Bug fixes for about:bookmarks:
e71f294 
- clear selection when click is outside of table
- clear selection when any element is dragged

Fixes #5223
Fixes #5249

Auditors: @darkdh

Test Plan:
1. Launch Brave and visit about:bookmarks
2. Import bookmarks or have bookmarks ready
3. Drag bookmarks from the view on the right over to a different folder
4. Observe that the selection is cleared
5. Use Ctrl or Cmd and select multiple items
6. Click below the table or click the header for the table
7. Notice the selection is cleared
This was referenced Nov 2, 2016
Closed
Closed
Closed
This was referenced Nov 4, 2016
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

srirambv commented Nov 7, 2016

@bsclifton This is working only on bookmarks. History entries still remains selected even after clicking outside the view. Checked it on both Windows and Ubuntu.

@srirambv srirambv changed the title Selected bookmark/history items doesn't clear selection when clicked outside the view Selected bookmark items don't clear selection when clicked outside the view Nov 7, 2016
@bsclifton bsclifton mentioned this issue Nov 7, 2016
Closed
@bsclifton
Copy link
Member

@srirambv I updated the title (and original post) for this issue to be only for Bookmarks Manager. I totally missed the "History" part when looking into this.

I created a follow-up issue we can use to track the issue w/ History:
#5458

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/bookmarks feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

Bug fixes for about:bookmarks
4 participants
@alexwykoff @luixxiul @bsclifton @srirambv