Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added context-menu option to close tabs in tab page #5489

Closed
bbondy opened this issue Nov 8, 2016 · 0 comments · Fixed by #6570
Closed

Added context-menu option to close tabs in tab page #5489

bbondy opened this issue Nov 8, 2016 · 0 comments · Fixed by #6570
Assignees
@NejcZdovc
Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@bbondy
Copy link
Member

bbondy commented Nov 8, 2016 •
edited by luixxiul
Loading

Test plan:

#6570 (comment)

I often find I don't need to use a tab page at all anymore and want to close the whole group, I end up right clicking on the tab page indicator, but then I don't see a close tab page option.
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 7, 2017
@NejcZdovc
Added close tab page
9d26755 
Resolves brave#5489

Auditors: @bbondy @bsclifton

Test Plan:
- open two tab pages
- right click on one and click close tab page
- all tabs in tab pages should be closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 7, 2017
@NejcZdovc
Added close tab page
292c3de 
Resolves brave#5489

Auditors: @bbondy @bsclifton

Test Plan:
- open two tab pages
- right click on one and click close tab page
- all tabs in tab pages should be closed
@NejcZdovc NejcZdovc mentioned this issue Jan 7, 2017
Merged
4 tasks
@NejcZdovc NejcZdovc self-assigned this Jan 9, 2017
@bsclifton bsclifton added this to the 0.13.2 milestone Jan 26, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 7, 2017
@NejcZdovc
Added close tab page
62d8cff 
Resolves brave#5489

Auditors: @bbondy @bsclifton

Test Plan:
- open two tab pages
- right click on one and click close tab page
- all tabs in tab pages should be closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 7, 2017
@NejcZdovc
Added close tab page
b4277d1 
Resolves brave#5489

Auditors: @bbondy @bsclifton

Test Plan:
- open two tab pages
- right click on one and click close tab page
- all tabs in tab pages should be closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 7, 2017
@NejcZdovc
Added close tab page
9d79860 
Resolves brave#5489

Auditors: @bbondy @bsclifton

Test Plan:
- open two tab pages
- right click on one and click close tab page
- all tabs in tab pages should be closed
@NejcZdovc NejcZdovc mentioned this issue Feb 15, 2017
Closed
@bbondy bbondy modified the milestones: 0.13.6, 0.13.5 Feb 16, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 26, 2017
@NejcZdovc
Added close tab page
08938d0 
Resolves brave#5489

Auditors: @bbondy @bsclifton

Test Plan:
- open two tab pages
- right click on one and click close tab page
- all tabs in tab pages should be closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 8, 2017
@NejcZdovc
Added close tab page
555eb87 
Resolves brave#5489

Auditors: @bbondy @bsclifton

Test Plan:
- open two tab pages
- right click on one and click close tab page
- all tabs in tab pages should be closed
@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 10, 2017
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 4, 2017
@NejcZdovc
Added close tab page
54cf311 
Resolves brave#5489

Auditors: @bbondy @bsclifton

Test Plan:
- open two tab pages
- right click on one and click close tab page
- all tabs in tab pages should be closed
cezaraugusto pushed a commit that referenced this issue Apr 5, 2017
@NejcZdovc @cezaraugusto
Close tab page option (#6570)
387738a 
* Added close tab page

Resolves #5489

Auditors: @bbondy @bsclifton

Test Plan:
- open two tab pages
- right click on one and click close tab page
- all tabs in tab pages should be closed

* Creating new frameReducer to handle closing tab page

Auditors: @NejcZdovc

* Moving close frame to new reducer

Auditors: @bsclifton
This was referenced Apr 9, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 13, 2017
Closed
This was referenced Apr 13, 2017
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Add context-menu option to close tabs in tab page Added context-menu option to close tabs in tab page Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Close tab page option NejcZdovc/browser-laptop
8 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv @cndouglas