Update / restyle for Preferences > Payments

[bsclifton]

Starting off with a picture (courtesy of @bradleyrichter)

Style updates include:

• sortableTable no longer hides it's style (should properly show the column headers)
• re-connected styles for all widgets with master styles

New functionality:

• "hide excluded sites" toggle
• exclude button on the left (in addition to the existing right click one)
  (for blacklisting sites that you don't want to see regardless of their include/exclude state)

[srirambv]

Some how Thanks for helping support your favorite website! doesn't sound right.

Instead can it be Thanks for your help in supporting your favorite website!

@bsclifton @bradleyrichter Thoughts ?

[bradleyrichter]

@srirambv How about the above string?

"Thanks for supporting your favorite websites!"

[srirambv]

Yes that sounds better 👍

[bsclifton]

@bradleyrichter anything else needed before we can start this one?

[bradleyrichter]

This is good to go until we add the ability to add an individual site.

[bradleyrichter]

@mrose17 @jkup

This is the task I had mentioned today...

[jkup]

yep it's in 0.12.11!

[jkup]

@mrose17 Is there an endpoint in ledger-client for blacklisting a site?

[mrose17]

there is no concept of "black-listing". there is a concept of an exclusion list. there are two, each browser has a private exclusion list (right click on a site on about:preferences#payments and select "Never include this site". there is also a global exclusion list, that is under review.

[jkup]

@mrose17 Ok this ticket looks to be calling for a feature that doesn't exist then? + @bsclifton

[mrose17]

i think you should DM @bsclifton and @bradleyrichter to see what they are looking for...

[bradleyrichter]

The "blacklist" column on the left is simply a more-accessible shortcut to the already existing context-menu for "never include this site":

This function is used for sites in which a user does not want to ever pay, or perhaps even see in their list. One example would be for a site that we have not added to our global exclude list yet but the user spend time there daily.

Youtube Red might be a good example.

Or an offensive click-bait site that was visited using a shared computer and user-A prefers that user-B does not see that the site was visited.

[bsclifton]

@jkup this would be a new feature 😄 There is something similar (but it's not done yet) which you can check out in js/about/history.js. There, you'll see a quick "delete" button on each row (which is currently hidden). This is all using the sortableTable control

[jkup]

@bsclifton ah ok cool.. how should I implement this? Do we add some global state for blacklistedSites or something like that? And then just check against that when we display the ledger table?

[bsclifton]

@jkup I think showing the FontAwesome Ban icon on hover and then executing the same code that is executed when picking "Never include this site" would do the trick 😄 No new functionality needed per-se, since you can already right click one by one, but offering a button as the first column will make it very easy to process your list

[jkup]

Ohhhhhh ok ok ok ok got it!

[bradleyrichter]

This "quick remove" column came from the original history makeover design.

Ideally we can use it there as well. It should work in a similar way to the the search engine prefs default column except that the hover state also shows the "no" symbol and clicking removes it from the list.

[luixxiul]

.titleBar and .walletBar are almost ready:

[bsclifton]

Issue is resolved with #6101, which is ready for merge (after 0.13.0 ships). Milestone is already set and is correct.

[bsclifton]

Fixed with #6101 which was merged into branch 0.13.1-branch.

Test Plan:

1. Open Brave
2. Go to Preferences > Payments
3. Toggle a site to not be included
4. Toggle hide excluded sites and make sure that one disappears
5. Make sure the general design looks like the mock in Update / restyle for Preferences > Payments #5494
6. Make sure clicking the remove button for a site removes it from the list