Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

typing over urlbar selection, should allow your typed change #5582

Closed
bbondy opened this issue Nov 13, 2016 · 1 comment
Closed

typing over urlbar selection, should allow your typed change #5582

bbondy opened this issue Nov 13, 2016 · 1 comment
Assignees
@bbondy
Labels
feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64
Milestone
0.12.9dev

Comments

@bbondy
Copy link
Member

bbondy commented Nov 13, 2016

  1. Have a history with brave.com
  2. In the urlbar type bra, then press down arrow to go to brave, or move mouse to highlight the suggestion
  3. Press x

It should allow you to type x and it should not use the suggestion text.
@bbondy bbondy added this to the 0.12.9dev milestone Nov 13, 2016
@bbondy bbondy self-assigned this Nov 13, 2016
@bbondy bbondy closed this as completed in b3a61d7 Nov 13, 2016
@alexwykoff alexwykoff mentioned this issue Nov 14, 2016
Closed
bbondy added a commit that referenced this issue Nov 14, 2016
@bbondy
Handle typing over selected suggestions
c9d80a9 
Auditors: @aekeus

This fixes the failing test: On suggestion mouseover, appends autocomplete URLs without interrupting typing

Fix #5582
This was referenced Nov 14, 2016
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
@luixxiul
Copy link
Contributor

luixxiul commented Nov 14, 2016 •
edited
Loading

  1. Have a history with brave.com
  2. In the urlbar type bra, then press down arrow to go to brave, or move mouse to highlight the suggestion
  3. Press x
  1. brax
  2. Open another tab and re-select the original one
  3. braxton hicks contractions, if you have enabled autocomplete of search terms (DDG)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.9dev
Development

No branches or pull requests
4 participants
@bbondy @alexwykoff @luixxiul @srirambv