Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

IPC is failing on C54 in renderer processes #6151

Closed
bbondy opened this issue Dec 12, 2016 · 3 comments
Closed

IPC is failing on C54 in renderer processes #6151

bbondy opened this issue Dec 12, 2016 · 3 comments
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.0

Comments

@bbondy
Copy link
Member

bbondy commented Dec 12, 2016 •
edited
Loading

Running this in Shift+F8 console fails:
chrome.ipcRenderer.emit('shortcut-focus-url')

This also fails various parts of functionality but most visible through automated test failures.
@bbondy bbondy added this to the 0.13.0 milestone Dec 12, 2016
@bbondy bbondy changed the title IPC is failing IPC is failing on C54 in renderer processes Dec 12, 2016
bbondy added a commit to brave/muon that referenced this issue Dec 12, 2016
@bbondy
Fix renderer IPC failing
f46584a 
This is failing a bunch of automated tests and general functionality.

Bug was introduced here:
96b2f08#diff-6d7213223d17eee94ce8a64e16ead954L29
The assignment was shortcircuited with `arguments[1] &&` before.

Fix brave/browser-laptop#6151

Auditors: @bridiver
@bbondy bbondy closed this as completed Dec 12, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor

Test plan:

Running this in Shift+F8 console should not fail:
chrome.ipcRenderer.emit('shortcut-focus'url')

@srirambv
Copy link
Collaborator

6151

cc: @bbondy this is on a clean install on 0.13.0 RC1

@luixxiul
Copy link
Contributor

I confirmed this was fixed on RC5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @bsclifton @srirambv