Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:newtab top site pins have the wrong z-index and are being hidden by top site icons #6281

Closed
alexwykoff opened this issue Dec 17, 2016 · 2 comments
Closed

about:newtab top site pins have the wrong z-index and are being hidden by top site icons #6281

alexwykoff opened this issue Dec 17, 2016 · 2 comments
Assignees
@cezaraugusto
Labels
bug QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.0

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When opening Brave for the first time, I attempted to pin the top sites on about:newtab. The pins were sometimes hidden due to the top sites icon size and the z-index of the pin.

Expected behavior:
The pin should be foremost to maintain access.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X

  • Brave Version:
    0.13.0 Preview 4

  • Steps to reproduce:

    1. Remove /brave
    2. Open 0.13.0 Preview 4
    3. Observe the pins on each of the top site tiles

  • Screenshot if needed:

  • Any related issues:
@alexwykoff alexwykoff added this to the 0.13.0 milestone Dec 17, 2016
@luixxiul
Copy link
Contributor

Note: most of the z-indexes are maintained in the variable.less

@cezaraugusto cezaraugusto self-assigned this Dec 17, 2016
@cezaraugusto cezaraugusto mentioned this issue Dec 17, 2016
Merged
3 tasks
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
cezaraugusto added a commit that referenced this issue Dec 20, 2016
@cezaraugusto
tweak on PinnedTopSite Icon to avoid overflow
a8a3728 
Fix #6281

Auditors: @luixxiul

Test Plan:

* Go to about:newtab
* Pin a site
* Pinned icon should not be overflown by favicon (should be aesthetically correct)
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor

Test plan: #6286 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @cezaraugusto @srirambv