Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

tab icons are not constrained to actual tab space #6845

Closed
alexwykoff opened this issue Jan 25, 2017 · 0 comments
Closed

tab icons are not constrained to actual tab space #6845

alexwykoff opened this issue Jan 25, 2017 · 0 comments

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Jan 25, 2017

Test plan

#6900 (comment)


  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    when opening a private tab then opening the developer's console, it was found that the icons were overhanging the tab.

this also happened when the number of tabs per set was 20

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    tested on os x

  • Brave Version (revision SHA):
    0.13.0 rc5

  • Steps to reproduce:

    1. open the max set of tabs per default set (10)
    2. for the last tab in the set, make it a private tab
    3. open the developer console (fn + shift + f8 on mac)
  • Actual result:
    the tab icons extend beyond the tab space

  • Expected result:
    tab icons should be constrained to the tab space

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    no, the current version is close, but constrained to the tab appropriately

screen shot 2017-01-24 at 10 30 18 pm

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

screen shot 2017-01-24 at 10 16 12 pm

screen shot 2017-01-24 at 10 12 36 pm

  • Any related issues:
@alexwykoff alexwykoff added this to the 0.13.1 milestone Jan 25, 2017
@bbondy bbondy modified the milestones: 0.13.2, 0.13.1 Jan 28, 2017
cezaraugusto added a commit that referenced this issue Feb 3, 2017
cezaraugusto added a commit that referenced this issue Feb 5, 2017
bsclifton pushed a commit that referenced this issue Feb 6, 2017
@bsclifton bsclifton modified the milestones: 0.13.3, 0.13.4 Feb 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants