Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark folder tree structure is not properly synced between devices #7293

Closed
srirambv opened this issue Feb 16, 2017 · 2 comments
Closed

Bookmark folder tree structure is not properly synced between devices #7293

srirambv opened this issue Feb 16, 2017 · 2 comments
Assignees
@diracdeltas
Labels
bug feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.5

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 16, 2017 •
edited
Loading

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Bookmark folder tree structure is not properly synced between devices

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.5
    rev 59a41eb

  • Steps to reproduce:

    1. Enable sync on two diff device and ensure bookmarks option is selected
    2. Import bookmark html file which has nested bookmark folders structure in pyramid 1
    3. The same folder structure is not followed in pyramid 0

  • Actual result:
    Bookmark folder tree structure is not properly synced between devices

  • Expected result:
    Both device should have the same folder structure

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    Pyramid 0
    image
    Pyramid 1
    image

  • Any related issues:
    some bookmarks not synced in the correct folder sync#49
@srirambv srirambv added this to the 0.13.5 milestone Feb 16, 2017
@srirambv
Copy link
Collaborator Author

cc: @ayumi

@diracdeltas
Copy link
Member

diracdeltas commented Feb 18, 2017 •
edited
Loading

i think this may be due to a race condition in getObjectById when calling applySiteRecord. if applySiteRecord is called for a bookmark UPDATE before the same bookmark's CREATE has propagated to appState, then getFolderIdByObjectId returns undefined, so the bookmark is not in any folder

i'm trying to address the same issue in #7309 right now

@diracdeltas diracdeltas mentioned this issue Feb 22, 2017
Merged
@diracdeltas diracdeltas self-assigned this Feb 24, 2017
diracdeltas added a commit that referenced this issue Feb 24, 2017
@diracdeltas
call a single appAction when receiving sync site records
00d3186 
fix #7308
fix #7293
fix #7307

Auditors: @ayumi @alexwykoff

Test Plan:
1. in about:preferences#sync, choose the 'i have an existing sync code' option. enter in the code words that Alex posted in #testers (starts with 'forsaken')
2. wait for 6000+ bookmarks to appear in the bookmarks toolbar. the browser should not freeze or use excessive memory during the sync. for me it takes about 5 seconds.
3. open about:bookmarks. you should see a bunch of folders with bookmarks, including subfolders.
This was referenced Mar 1, 2017
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.5
Development

No branches or pull requests
4 participants
@diracdeltas @alexwykoff @luixxiul @srirambv