Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Include switch is enabled by default for publishers even though auto include is turned off #7429

Closed
srirambv opened this issue Mar 1, 2017 · 1 comment

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 1, 2017

Test plan:

#7439 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Include switch is enabled by default for publishers even though auto include is turned off

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.5
    rev 7373a01

  • Steps to reproduce:

    1. Enable payments in 0.13.5 Preview 3
    2. Turn off auto include switch in payments window
    3. Visit any site which is not on the exclude list, Site is listed and include switch is turned on by default
  • Actual result:
    Include switch is enabled by default for publishers even though auto include is turned off

  • Expected result:
    Should only list the publisher but not include it

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    autoinclude
    autoinclude_134

  • Any related issues:
    cc: @mrose17 @cezaraugusto

@srirambv srirambv added this to the 0.13.5 milestone Mar 1, 2017
@cezaraugusto
Copy link
Contributor

thanks for reporting. New logic for publishers sets disabled by default if auto suggest is off.

There's a fix for that but not ready for review so let's keep this open until it is

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.