Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed audio indicator has extra bottom padding compared to favicon #7815

Closed
srirambv opened this issue Mar 21, 2017 · 1 comment · Fixed by #7854
Closed

Fixed audio indicator has extra bottom padding compared to favicon #7815

srirambv opened this issue Mar 21, 2017 · 1 comment · Fixed by #7854
Assignees
@cezaraugusto @bsclifton
Labels
design A design change, especially one which needs input from the design team. OS/Windows QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Audio indicator has extra bottom padding compared to favicon

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.14.0
    rev 64b381a

  • Steps to reproduce:

    1. Open any audio/video site and play to show the audio indicator
    2. Position of the icon is off compared to favicon
      @cezaraugusto confirmed its fine on macOS and Linux. Issue on Windows only

  • Actual result:
    Audio indicator has extra bottom padding compared to favicon

  • Expected result:
    Should be at same level as favicon

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @cezaraugusto
@srirambv srirambv added design A design change, especially one which needs input from the design team. OS/Windows QA/test-plan-specified labels Mar 21, 2017
@srirambv srirambv added this to the 0.14.0 milestone Mar 21, 2017
@bsclifton
Copy link
Member

@cezaraugusto can you check this out?

@bsclifton bsclifton self-assigned this Mar 23, 2017
@bsclifton bsclifton mentioned this issue Mar 23, 2017
Merged
4 tasks
cezaraugusto pushed a commit that referenced this issue Mar 23, 2017
@bsclifton @cezaraugusto
Ensure audio icon on tab is vertically centered (it only seemed to be…
3525fdb 
… a problem on Windows, > 100% DPI) (#7854)

Fixes #7815

Auditors: @cezaraugusto, @srirambv

Test Plan:
1. Be on a Windows machine which is set at 125% DPI
2. Launch Brave and visit youtube.com
3. Click the first link you see and let the video play
4. Ensure you're at a # of tabs where audio icon is showing (if not, close some tabs)
5. Audio icon should look vertically centered now
@alexwykoff alexwykoff mentioned this issue Mar 24, 2017
Closed
@alexwykoff alexwykoff changed the title Audio indicator has extra bottom padding compared to favicon Fixed audio indicator has extra bottom padding compared to favicon Mar 24, 2017
This was referenced Mar 28, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

@bsclifton bsclifton

Labels
design A design change, especially one which needs input from the design team. OS/Windows QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Ensure audio icon on tab is vertically centered
5 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv