This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
frame location is updated too soon #7894
Comments
bridiver
added a commit
that referenced
this issue
Mar 25, 2017
fix #7880 requires brave/muon@42b9c96 note: url will not properly reset until #7894 is fixed
3 tasks
bridiver
changed the title
location is updated too soon
frame location is updated too soon
Mar 25, 2017
this information is sometimes available in the |
we could use that for this case, but what we're calling |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
When navigating through the urlbar (and some other methods) the frame location is set immediately. This causes a problem for provisional load failures because they lose the original location to reset the urlbar.
windowActions.loadUrl
should set the provisional location and the actual location should be set onload-start
. That allows certain types ofdid-fail-provisional-load
(aborted for instance) failures to set the urlbar back to the provisionalLocation without reloading the page.Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version (revision SHA):
396cdbc
The text was updated successfully, but these errors were encountered: