Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

frame location is updated too soon #7894

Closed
bridiver opened this issue Mar 25, 2017 · 2 comments
Closed

frame location is updated too soon #7894

bridiver opened this issue Mar 25, 2017 · 2 comments

Comments

@bridiver
Copy link
Collaborator

bridiver commented Mar 25, 2017

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    When navigating through the urlbar (and some other methods) the frame location is set immediately. This causes a problem for provisional load failures because they lose the original location to reset the urlbar. windowActions.loadUrl should set the provisional location and the actual location should be set on load-start. That allows certain types of did-fail-provisional-load (aborted for instance) failures to set the urlbar back to the provisionalLocation without reloading the page.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    396cdbc

bridiver added a commit that referenced this issue Mar 25, 2017
fix #7880
requires brave/muon@42b9c96

note: url will not properly reset until #7894 is fixed
@bridiver bridiver changed the title location is updated too soon frame location is updated too soon Mar 25, 2017
@bridiver bridiver added the bug label Mar 25, 2017
@bridiver
Copy link
Collaborator Author

this information is sometimes available in the did-fail-provisional-load event, but that method uses GetURL and should use GetLastCommittedURL. GetURL returns the visible entry which should be correct after the load failure in DidFinishNavigation, but to be safe it should always be GetLastCommittedURL

@bridiver
Copy link
Collaborator Author

bridiver commented Mar 25, 2017

we could use that for this case, but what we're calling provisionalLocation in browser-laptop is not the provisional location which is really confusing because provisional load failures can only happen before load-start

@luixxiul luixxiul added this to the 1.0.0 milestone May 29, 2017
@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Nov 1, 2017
@cezaraugusto cezaraugusto modified the milestone: Triage Backlog Nov 8, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants