Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix Standard.js lint errors #8061

Closed
luixxiul opened this issue Apr 4, 2017 · 3 comments · Fixed by #7951
Closed

Fix Standard.js lint errors #8061

luixxiul opened this issue Apr 4, 2017 · 3 comments · Fixed by #7951
Assignees
@NejcZdovc
Labels
infrastructure QA/no-qa-needed release-notes/exclude
Milestone
0.15.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Apr 4, 2017

Describe the issue you encountered: Fix Standard.js lint errors.

Adding the priority/high label as the errors appear everytime on commit and makes it difficult to detect if errors are related with the commit which you are going to create.

  • Any related issues:
@NejcZdovc
Copy link
Contributor

@luixxiul I already fix this in #7951

@NejcZdovc NejcZdovc self-assigned this Apr 4, 2017
@NejcZdovc NejcZdovc added this to the 0.14.2 milestone Apr 4, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 4, 2017
@NejcZdovc
Linter fixes
1ae0c8b 
Resolves brave#8061
@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 4, 2017

Sweet. Would you please merge this into the master asap?

If you will continue to work on that PR, I would like to ask you to cherry-pick the commit and create another PR which has the commit only, since it seems that it would take some time to review all of the commits there. Thanks!

@NejcZdovc
Copy link
Contributor

This PR is done and just needs to be reviewed

@NejcZdovc NejcZdovc mentioned this issue Apr 4, 2017
Merged
4 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 4, 2017
@NejcZdovc
Linter fixes
f8f26c8 
Resolves brave#8061
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 5, 2017
@NejcZdovc
Linter fixes
7da2788 
This is a follow up of brave#7813 and resolves linter errors

Resolves brave#8061
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 5, 2017
@NejcZdovc
Linter fixes
e9cfed6 
This is a follow up of brave#7813 and resolves linter errors

Resolves brave#8061
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 5, 2017
@NejcZdovc
Linter fixes
8394d84 
This is a follow up of brave#7813 and resolves linter errors

Resolves brave#8061
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 5, 2017
@NejcZdovc
Linter fixes
80ad10a 
This is a follow up of brave#7813 and resolves linter errors

Resolves brave#8061
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 5, 2017
@NejcZdovc
Linter fixes
361753b 
This is a follow up of brave#7813 and resolves linter errors

Resolves brave#8061
@alexwykoff alexwykoff mentioned this issue Apr 14, 2017
Closed
82 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
infrastructure QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Automated tests fixes and refactoring NejcZdovc/browser-laptop
2 participants
@luixxiul @NejcZdovc