This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
unable to open a partitioned/private link - tab props always false #8271
Assignees
Labels
Milestone
Comments
|
worth mentioning: opening a new partitioned/private tab using menu/long press newtab menu and shortcuts works ok. Issue is regarding tabs. |
4 tasks
bsclifton
added a commit
that referenced
this issue
Apr 13, 2017
…b` were not opening in a private tab. During app/browser/tab::create(), `isPrivate` is set to true. However, there is no partition set. If this is missing, I believe the code is checking the opener (which is not correct in this case). When handler `add-new-contents` fired, the `incognito` property was always set to false. Partition `default` seems to match picking "New private tab" from file menu and hitting + button > New private tab in tabs bar After review by @bbondy, this also makes sure to assign partition if isPartitioned/partitionNumber are set (same conditions as checked in getPartition) Fixes #8271 Auditors: @bbondy, @bridiver Test Plan: 1. Go to https://slashdot.org/ 2. Right click any link and pick (from the context menu) `Open Link in New Private Tab` 3. Confirm tab that opens is private 4. Close private tab, go back to slashdot.org 5. Right click a link and pick (from the context menu) `Open Link in New Session Tab` 6. Go back to slashdot.org and repeat step 5 7. You should now have two session tabs opened, each with a different ID
This was referenced Apr 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
Open Link in New Private TabOpen Link in New Session TabOriginal issue description
Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
I can't go to a private/partitioned tab by clicking on a link
Platform (Win7, 8, 10? macOS? Linux distro?):
any
Brave Version (revision SHA):
adf4d9a
Steps to reproduce:
Actual result:
If you log
this.props.tab.get('isPrivate')orthis.props.tab.get('partitionNumber')on tabs you will always see false/0 respectivelly. Based on that, tab is not private nor partitioned (no icon indicators).Expected result:
Should return true for privateTabs and return the partitionNumber for newSession tabs. Indicators for each tab should follow pattern: sunglass for private/person + number for partitioned tabs.
Will the steps above reproduce in a fresh profile? If not what other info can be added?
yes
Is this an issue in the currently released version?
Yes, reproducible on v0.14.2dev-Preview3
Can this issue be consistently reproduced?
yes
The text was updated successfully, but these errors were encountered: