Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clicking ledger register button breaks add funds button #8359

Closed
luixxiul opened this issue Apr 17, 2017 · 0 comments
Closed

Clicking ledger register button breaks add funds button #8359

luixxiul opened this issue Apr 17, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Apr 17, 2017

Test Plan:

#8382 (comment)


Describe the issue you encountered: Clicking ledger register button breaks add funds button.

generate.js:169 Uncaught TypeError: Cannot read property 'forEach' of undefined
    at generateCSS (generate.js:169)
    at injectStyleOnce (inject.js:167)
    at injectAndGetClassName (inject.js:250)
    at css (exports.js:146)
    at BitcoinDashboard.render (bitcoinDashboard.js:344)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (ReactCompositeComponent.js:799)
    at ReactCompositeComponentWrapper._renderValidatedComponent (ReactCompositeComponent.js:822)
    at ReactCompositeComponentWrapper.performInitialMount (ReactCompositeComponent.js:362)
    at ReactCompositeComponentWrapper.mountComponent (ReactCompositeComponent.js:258)
    at Object.mountComponent (ReactReconciler.js:46)
  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32bit

  • Brave Version (revision SHA): 0.14.2 RC2

  • Steps to reproduce:

    1. Open https://jsfiddle.net/LnwtLckc/5/
    2. Click "register" and then choose "Allow"
    3. Open about:preferences#payments
    4. Click "Add funds"
  • Expected result: "Transfer BTC" button should be displayed on the modal dialog

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@NejcZdovc NejcZdovc added this to the 0.14.2 milestone Apr 17, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 17, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 18, 2017
Resovles brave#8359

Auditors: @bsclifton @luixxiul

Test Plan:
- Open https://jsfiddle.net/LnwtLckc/5/
- Click "register"
- Open about:preferences#payments
- Click "Add funds"
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 18, 2017
Resolves brave#8359

Auditors: @bsclifton @luixxiul

Test Plan:
- Open https://jsfiddle.net/LnwtLckc/5/
- Click "register"
- Open about:preferences#payments
- Click "Add funds"
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 18, 2017
Resolves brave#8359

Auditors: @bsclifton @luixxiul

Test Plan:
- Open https://jsfiddle.net/LnwtLckc/5/
- Click "register"
- Open about:preferences#payments
- Click "Add funds"
bsclifton added a commit that referenced this issue Apr 18, 2017
bsclifton pushed a commit that referenced this issue Apr 18, 2017
Resolves #8359

Auditors: @bsclifton @luixxiul

Test Plan:
- Open https://jsfiddle.net/LnwtLckc/5/
- Click "register"
- Open about:preferences#payments
- Click "Add funds"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.