Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

opening pdf in new tab fails to load #8364

Closed
diracdeltas opened this issue Apr 17, 2017 · 4 comments · Fixed by #8366
Closed

opening pdf in new tab fails to load #8364

diracdeltas opened this issue Apr 17, 2017 · 4 comments · Fixed by #8366
Assignees
@diracdeltas
Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.15.0

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Apr 17, 2017 •
edited by bsclifton
Loading

Test plan:

  1. go to https://letsencrypt.org/repository/
  2. right click on any of the PDF links to open in a new tab. it should work.
  3. right click on any of the PDF links to open in a new private tab. it should work.

Original issue description

  • Did you search for similar issues before submitting this one?
    yes

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    0.14.1 / pdfjs 1.7.428

  • Steps to reproduce:

    1. right-click to open a pdf file in a new tab with pdf.js enabled
    2. the pdf does not load
@diracdeltas diracdeltas added this to the 0.15.1 milestone Apr 17, 2017
@diracdeltas diracdeltas self-assigned this Apr 18, 2017
diracdeltas added a commit that referenced this issue Apr 18, 2017
@diracdeltas
fix PDFJS loading PDFs in new tabs
121a3bb 
fix #8364

also adds LOAD_URL_REQUESTED message handler, which is needed for brave/pdf.js#2

test plan:
1. go to https://letsencrypt.org/repository/
2. right click on any of the links to open in a new tab. it should work.
3. right click on any of the links to open in a new private tab. it should work.
@diracdeltas diracdeltas mentioned this issue Apr 18, 2017
Merged
4 tasks
@diracdeltas diracdeltas modified the milestones: 0.14.2, 0.15.1 Apr 18, 2017
bsclifton pushed a commit that referenced this issue Apr 18, 2017
@diracdeltas @bsclifton
fix PDFJS loading PDFs in new tabs
fcf9a55 
fix #8364

also adds LOAD_URL_REQUESTED message handler, which is needed for brave/pdf.js#2

test plan:
1. go to https://letsencrypt.org/repository/
2. right click on any of the links to open in a new tab. it should work.
3. right click on any of the links to open in a new private tab. it should work.
This was referenced Apr 18, 2017
Closed
Closed
Closed
Closed
@cezaraugusto
Copy link
Contributor

doesn't work on Ubuntu. "Save as" dialog opens while opening on the same page but not for new tab/new private tab. Reopening

@cezaraugusto cezaraugusto reopened this Apr 22, 2017
@bsclifton
Copy link
Member

This works great for me on Ubuntu 14.04 using 0.15.0 RC3

Can you retest this, @cezaraugusto?

@bsclifton
Copy link
Member

Also confirmed it works great on Ubuntu 16.04

@cezaraugusto
Copy link
Contributor

I'm still not able to open PDF running the executable, but I did a new shot checking out RC3 tag branch and it worked. I can't say why as both are running muon 2.58.4.

This is labeled as working on macOS and tested on two diff Ubuntu versions working good, so I'll close and keep an eye on RC4. @bsclifton thanks for tracking 🥇

@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title opening pdf in new tab fails to load Fixed opening pdf in new tab fails to load Apr 25, 2017
@luixxiul luixxiul changed the title Fixed opening pdf in new tab fails to load opening pdf in new tab fails to load Aug 20, 2017
@humphd humphd mentioned this issue Mar 24, 2018
Merged
@diracdeltas diracdeltas mentioned this issue Jul 26, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

fix PDFJS loading PDFs in new tabs brave/browser-laptop
7 participants
@diracdeltas @alexwykoff @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv