Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove store logic from windowActions #8380

Closed
NejcZdovc opened this issue Apr 18, 2017 · 0 comments
Closed

Remove store logic from windowActions #8380

NejcZdovc opened this issue Apr 18, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 18, 2017 •
edited by luixxiul
Loading

Test Plan

#8381 (comment)

  1. tests should be green
  2. mute a tab (click on a volume icon in a tab that is playing some music)
  3. mute a tab (right click on a tab and select it from the context menu)
  4. mute other tabs (right click on a tab and select it from the context menu)
  5. mute/un-mute whole tab page (right click on a tab page and select it from the context menu)

Original issue description

Describe the issue you encountered:
Remove store logic from windowActions. This ways windowActions can be used in other processes as well.
@NejcZdovc NejcZdovc added this to the 0.14.2 milestone Apr 18, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 18, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 18, 2017
@NejcZdovc
Removes store logic from windowActions
382a84d 
Resolves brave#8380

Auditors: @bsclifton

Test Plan:
- tests should be green
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 18, 2017
@NejcZdovc
Removes store logic from windowActions
d7c8ab4 
Resolves brave#8380

Auditors: @bsclifton

Test Plan:
- tests should be green
@NejcZdovc NejcZdovc mentioned this issue Apr 18, 2017
Merged
4 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.15.0, 0.14.2, 0.15.1 Apr 18, 2017
bsclifton added a commit that referenced this issue Apr 19, 2017
@bsclifton
Merge pull request #8381 from NejcZdovc/hotfix/#8380-window-actions
90d9290 
Removes store logic from windowActions
This was referenced May 2, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
5 participants
@alexwykoff @luixxiul @bsclifton @NejcZdovc @srirambv