Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove whole frame from onTabsToolbarContextMenu #8562

Closed
NejcZdovc opened this issue Apr 28, 2017 · 0 comments
Closed

Remove whole frame from onTabsToolbarContextMenu #8562

NejcZdovc opened this issue Apr 28, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 28, 2017 •
edited by luixxiul
Loading

Test plan

#8564 (comment)

Describe the issue you encountered:
Remove the whole frame param from onTabsToolbarContextMenu, so that we can use the full power of redux component. Provide only what is needed.
@NejcZdovc NejcZdovc added this to the 0.15.2 milestone Apr 28, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 28, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 28, 2017
@NejcZdovc
Removes whole frame from onTabsToolbarContextMenu
221cfa7 
Resolves brave#8562

Auditors: @bsclifton

Test Plan:
- open http://clifton.io
- right click on bookmarks toolbar
- click add bookmarks
- populated bookmark dialog is shown
@NejcZdovc NejcZdovc mentioned this issue Apr 28, 2017
Merged
4 tasks
cezaraugusto added a commit that referenced this issue May 5, 2017
@cezaraugusto
Merge pull request #8564 from NejcZdovc/hotfix/#8562-contextmenu
a0eb5ca 
Removes whole frame from onTabsToolbarContextMenu
This was referenced May 5, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @NejcZdovc @srirambv