importing bookmarks after sync causes loss of hierarchy

[alexwykoff]

Test plan

#9406 (comment)

---

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  I installed 0.15.304 on two different OS X laptops

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS

• Brave Version (revision SHA):
  0.15.304 (b872523)

• Steps to reproduce:

  1. with a clean profile for each, enable a new sync group on one device
  2. join the sync group with the other device
  3. import bookmarks on the primary device

• Actual result:
  the folder hierarchy is lost versus if an import occurs without sync.

• Expected result:
  the folder hierarchy should be maintained and the name should match the pattern 'imported from '

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  yes

• Is this an issue in the currently released version?
  likely

• Can this issue be consistently reproduced?
  yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:

• Any related issues:

[benmordecai]

I have experienced this same problem in Windows 10 x64, 0.15.314

[alexwykoff]

Confimed this is still an issue with 0.16.3:
laptop - laptop
laptop - iOS sync beta
laptop - android sync beta

[alexwykoff]

This is a pretty serious blocker for mobile implementations of sync as they don't have easy ways to organize mass amounts of bookmarks.

[bsclifton]

@diracdeltas do you think this can be solved for the 0.17.x release?

[diracdeltas]

@bsclifton probably

[benmordecai]

There is also a coincident bug where you cannot reliably drag and drop bookmarks in the manager so if sync fails you have to manually move bookmarks from the bookmark toolbar. This makes a sync failure basically unworkable on desktop/laptop also.

[diracdeltas]

the issue is that under certain timing conditions, the objectId property is set twice for a bookmarks folder, once in findOrCreateFolderObjectId when one of its children is being sent and once in createSiteData when it itself is being sent. the child ends up having a parentFolderObjectId that doesn't map to any object so it shows up at the top level.