Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Switching tabs to browser about pages is slow (e.g. new tab about:blank) #9004

Closed
ayumi opened this issue May 22, 2017 · 1 comment
Closed

Switching tabs to browser about pages is slow (e.g. new tab about:blank) #9004

ayumi opened this issue May 22, 2017 · 1 comment
Assignees
@ayumi
Labels
feature/about-pages feature/newtab perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@ayumi
Copy link
Contributor

ayumi commented May 22, 2017 •
edited by luixxiul
Loading

Test plan

#9015 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    With 10K bookmarks loaded, I found that switching to browser about pages is noticeably slower than webpages.
    I tried:

    • New tab: Dashboard
    • New tab: Blank
    • Preferences
    • History
    • About Brave

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    c36af01

  • Steps to reproduce:

    1. Load 10K bookmarks into Brave.
    2. Set Preferences > New tab page to Blank.
    3. Go to github.com.
    4. Open a new tab and go to archive.org.
    5. Open a new tab.
    6. Switch between tab 0, 1, and 2 using Ctrl+Tab while observing switching latency.

  • Actual result:
    Switching to tab 0 and 1 (real webpages) is fast.
    Switching to tab 2 (about blank) is slow.

  • Expected result:
    Switching to about pages should be fast.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Kind of– switching to the new tab dashboard is slightly slower.
    However the lag is most noticeable with 10K bookmarks.

  • Is this an issue in the currently released version?
    Yes
@ayumi ayumi changed the title Switching tabs to browser about pages is slow Switching tabs to browser about pages is slow (e.g. new tab about:blank) May 23, 2017
@ayumi ayumi self-assigned this May 23, 2017
ayumi added a commit that referenced this issue May 23, 2017
@ayumi
Avoid iterating all sites on every about page
fa5e987 
Fix #9004

Auditors: @bsclifton

Test Plan:
0. Check that tests pass.
1. Bookmark a page
2. Make a bookmark folder
3. Open Bookmarks manager and confirm bookmark page and folder.
@ayumi ayumi mentioned this issue May 23, 2017
Merged
7 tasks
@luixxiul luixxiul added this to the 0.15.300 milestone May 24, 2017
This was referenced May 25, 2017
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Note: Considerable performance improvement on Windows but the lag in switching to new tab(about:blank/dashboard) or about pages is still noticeable

@bbondy bbondy mentioned this issue May 26, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ayumi ayumi

Labels
feature/about-pages feature/newtab perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@ayumi @alexwykoff @luixxiul @srirambv