Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

When using IME results are shown before selection is made #9139

Closed
luixxiul opened this issue May 30, 2017 · 7 comments · Fixed by #12172
Closed

When using IME results are shown before selection is made #9139

luixxiul opened this issue May 30, 2017 · 7 comments · Fixed by #12172
Assignees
@darkdh
Labels
bug feature/URLbar l10n QA/checked-macOS QA/test-plan-specified regression release-notes/include
Milestone
0.22.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 30, 2017 •
edited by bsclifton
Loading

Test plan

#12172 (comment)

Describe the issue you encountered:
Some search queries in URL bar autocomplete suggestion are tofu. I susupect this is related with bloodhound upgrade as I have not seen this in previous versions.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

  • Brave Version (revision SHA): 0.15.310

  • Steps to reproduce:

    1. Have IME setup for Chinese / Japanese / other language
    2. Open about:preferences#search
    3. Enable google.com as default search
    4. Enable the last option on the preference page
    5. Set you brave's lang setting to Japanese
    6. Open a tab
    7. Input a few characters
    8. Search terms show even though IME selection not made (notice underline in URL bar)

    screen shot 2018-02-08 at 10 21 01 pm
@luixxiul luixxiul added this to the 0.16.200 milestone May 30, 2017
@alexwykoff
Copy link
Contributor

@luixxiul can you try vs 0.14 and update with more specific steps?

@alexwykoff alexwykoff modified the milestones: 0.19.x (Nightly Channel), 0.18.x (Developer Channel) Jun 13, 2017
@darkdh
Copy link
Member

darkdh commented Jun 13, 2017

In Traditional Chinese,
Brave
screen shot 2017-06-13 at 10 49 22 am
Chrome
screen shot 2017-06-13 at 10 50 00 am

@luixxiul
Copy link
Contributor Author

The issue cannot be reproduced with 0.15.2, on Windows 10.

@luixxiul
Copy link
Contributor Author

clipboard01

with af7ef42.

This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor Author

On 0.19.7

clipboard01

@luixxiul luixxiul reopened this Sep 20, 2017
@luixxiul luixxiul removed this from the 0.19.x (Beta Channel) milestone Sep 20, 2017
@luixxiul luixxiul mentioned this issue Oct 5, 2017
Closed
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@darkdh darkdh self-assigned this Dec 4, 2017
darkdh added a commit that referenced this issue Dec 4, 2017
@darkdh
Using composition event to detect IME composition stage ends
d102eed 
fix #9139

Auditors: @bsclifton, @bbondy

Test Plan:

1. Make sure you have IME which has composition state
(like Zhuyin in Chinese, some Japanese IME)
2. Enter the characters in the IME, make sure doing some
add/remove/select characters before ending composition state
(mostly pressing enter)
3. Autocomplete will show only after you complete the words/sentences
@darkdh darkdh mentioned this issue Dec 4, 2017
Merged
8 tasks
@bsclifton bsclifton removed this from the Triage Backlog milestone Jan 2, 2018
@bsclifton bsclifton added this to the 0.21.x (Developer Channel) milestone Jan 2, 2018
bsclifton pushed a commit that referenced this issue Feb 8, 2018
@darkdh @bsclifton
Using composition event to detect IME composition stage ends
59e39ad 
fix #9139

Auditors: @bsclifton, @bbondy

Test Plan:

1. Make sure you have IME which has composition state
(like Zhuyin in Chinese, some Japanese IME)
2. Enter the characters in the IME, make sure doing some
add/remove/select characters before ending composition state
(mostly pressing enter)
3. Autocomplete will show only after you complete the words/sentences
@bsclifton bsclifton changed the title Some search queries in URL bar autocomplete suggestion are tofu When using IME results are shown before selection is made Feb 9, 2018
This was referenced Feb 20, 2018
Closed
Closed
Closed
This was referenced Mar 22, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

This was referenced Mar 28, 2018
Closed
Closed
Closed
@kjozwiak
Copy link
Member

Went through the above STR with both @darkdh and @bsclifton using Ubuntu & Windows. Noticed that the autocomplete results are not being displayed once text via IME has been entered into the URL bar. Created #13639 to address the issue.

We'll release what we have now but will make a note in the release notes indicating that this fix only works on macOS.

@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/URLbar l10n QA/checked-macOS QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Using composition event to detect IME composition stage ends brave/browser-laptop
6 participants
@alexwykoff @kjozwiak @luixxiul @bsclifton @darkdh @LaurenWags