Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

'autocomplete search term' results are not filtering out 'http...' results #9141

Closed
srirambv opened this issue May 30, 2017 · 6 comments
Closed

'autocomplete search term' results are not filtering out 'http...' results #9141

srirambv opened this issue May 30, 2017 · 6 comments
Assignees
@diracdeltas
Labels
bug feature/autocomplete feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.15.311 (Frozen,...

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 30, 2017 •
edited by luixxiul
Loading

Test plan

#9155 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Selecting suggested FQDN causes search instead of opening the site

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.16.0
    rev be76cd3
    Muon 3.2.101

  • Steps to reproduce:

    1. Install/Upgrade to 0.15.310
    2. Disable all options except Autocomplete search term under search in preferences
    3. Type bug in the URL to show up the search suggestions
    4. Select www.bugatti.com from suggested items, searches instead of opening the site

  • Actual result:

  • Expected result:

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
    Bloodhound for URL bar suggestions & move suggestions to browser process #8824
    cc: @bbondy
@diracdeltas
Copy link
Member

what was the behavior in previous releases?

@diracdeltas diracdeltas self-assigned this May 30, 2017
@diracdeltas
Copy link
Member

so in 0.15.2, http://www.bugatti.com doesn't show up in the results at all. however, if you type http and click on the http://yahoo.com result, it does search instead of going to the FQDN. so i'm not sure this behavior is a bug.

@luixxiul
Copy link
Contributor

Is this the issue which is discussed?

clipboard01

Hitting Enter then returns a search result on Google instead of opening it directly.

@diracdeltas
Copy link
Member

@luixxiul i clicked instead of hitting enter but yeah i think it is the issue. the same thing happened in 0.15.2 if you selected an entry starting with 'http'

@diracdeltas
Copy link
Member

diracdeltas commented May 30, 2017 •
edited
Loading

it seems the underlying issue is that 'http...' entries should not be showing up in search results all the time, since it is pretty rare that they are used as search terms.

@diracdeltas
Copy link
Member

diracdeltas commented May 30, 2017 •
edited
Loading

confirmed that the 'http' results appear far less often in search results in 0.15.2. that seems to be the actual regression here.

@diracdeltas diracdeltas changed the title Selecting suggested FQDN causes search instead of opening the site 'autocomplete search term' results are not filtering out 'http..' results May 30, 2017
@diracdeltas diracdeltas changed the title 'autocomplete search term' results are not filtering out 'http..' results 'autocomplete search term' results are not filtering out 'http...' results May 30, 2017
diracdeltas added a commit that referenced this issue May 31, 2017
@diracdeltas
Deprioritize search suggestions that start with 'http'
d37f325 
Fix #9141

Test Plan:
1. automated tests related to search suggestions should pass
2. Disable all options except 'Autocomplete search term' under search in preferences
3. type 'bug' in the URL bar. you should not see any results that start with 'http'
4. type 'http' in the URL bar. you should see some results that start with 'http'.
@diracdeltas diracdeltas mentioned this issue May 31, 2017
Merged
7 tasks
This was referenced May 31, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/autocomplete feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.15.311 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@diracdeltas @alexwykoff @luixxiul @srirambv