Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

ledger balance updater doesn't turn on/off when payments tab is activated #9317

Closed
bridiver opened this issue Jun 7, 2017 · 0 comments · Fixed by #9318
Closed

ledger balance updater doesn't turn on/off when payments tab is activated #9317

bridiver opened this issue Jun 7, 2017 · 0 comments · Fixed by #9318

Comments

@bridiver
Copy link
Collaborator

bridiver commented Jun 7, 2017

Test plan

  1. Launch Brave and open Preferences > Payments
  2. Enable Brave Payments
  3. If you'd like to ensure the balance is being fetched properly, restore a wallet (otherwise, you can test knowing it's always $0)
  4. Verify the balance is shown
  5. Switch tabs (open a tab, go to brave.com for example)
  6. Switch back to the Preferences > Payment tab. It should re-fetch the balance
  7. Close the Preferences > Payments tab
  8. Re-open the Preferences > Payments tab
  9. Verify the balance is shown

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    https://github.com/brave/browser-laptop/blob/master/app/renderer/components/main/main.js#L514
    uses tabs, but tabs has been removed from windowState
    This change also makes the check substantially more efficient

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    6ec909c

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@bridiver bridiver added this to the 0.18.x milestone Jun 7, 2017
@bridiver bridiver self-assigned this Jun 7, 2017
bridiver added a commit that referenced this issue Jun 7, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.17.x (Beta Channel), 0.18.x (Developer Channel) Jun 13, 2017
bridiver added a commit that referenced this issue Jun 14, 2017
bridiver added a commit that referenced this issue Jun 14, 2017
bridiver added a commit that referenced this issue Jun 14, 2017
bridiver added a commit that referenced this issue Jun 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.