Import passwords from Chrome

[darkdh]

Test plan:

1. Make sure you have password and never save password list on Chrome/Canary/Chromium
2. Import password from the browsers list in step1 on Mac/Windows/Gnome Linux

KDE linux has a bug tracking brave/muon#238

---

based on #9292
including passwords list and never saved list

[srirambv]

Doesnt store imported password in about:passwords on Windows

[darkdh]

Remember to close Chrome before importing

[kjozwiak]

Importing passwords into Brave from either Chrome/Chromium doesn't work under Linux, specifically Ubuntu in this case. I haven't tried other linux distro's. When you attempt to import the passwords, usually two things happen:

You'll either get the message that everything has been imported, but when you look into about:passwords, nothing is being listed.

Or you'll get the following error messages when you attempt to import via Brave:

Example of the issue:

STR:

• install "Chromium" using "Ubuntu Software"
• install "Chrome" using the .deb package downloaded from Google's site via sudo dpkg -i
• launch either Chrome/Chromium, login into several websites and save the passwords via the permission prompt
• once you've saved the passwords, close Chrome/Chromium
• check Passwords & Keys under Ubuntu and ensure that all the passwords are being listed
• download the latest Brave .deb package and install via sudo dpkg -i
• launch Brave from the terminal via brave
• visit about:preferences and attempt to import the passwords into Brave

Platforms tested against:

• Ubuntu 17.04 x64 VM - FAILED (couldn't import passwords)
• Ubuntu 16.04 x64 VM - FAILED (couldn't import passwords)
• Ubuntu 16.04 x64 Lenovo X1 - FAILED (couldn't import passwords)

I've also tried both packaged and dev (from source) builds and received the same results.

Builds used:

• v0.19.27 rev: e7f3a69 - Reproduced
• v0.19.25 rev: d4fd17a - Reproduced

@darkdh, I ended up installing Ubuntu 16.04 on a old Lenovo X1 and I could still reproduce the issue so it's definitely not related to VM's.

[kjozwiak]

@luixxiul, @srirambv, @LaurenWags can one of you please try this and see if importing from Chrome/Chromium works under Ubuntu?

[luixxiul]

On Debian, 0.19.27, password saved on trac.torproject.org can be successfully imported from Chromium to Brave.

[bbondy]

seems at least partial, I'm fine with pushing this out of this milestone or if you post a smaller sub-task if it's easier.

[srirambv]

On Ubuntu, 0.19.28, password saved on overleaf.com wasnt imported. But showed error when data was imported data from Chrome

[kjozwiak]

Looks like importing the "Cookies" from Chrome/Chromium causes the crash which @darkdh confirmed as well. I went through the following verification process:

Ubuntu 17.04 x64: PASSED

• importing passwords from Chrome 61.0.3163.100 into v0.19.28 rev: 08781a5 - PASSED
• importing passwords from Chromium 61.0.3163.79 into v0.19.28 rev: 08781a5 - PASSED

Ubuntu 16.04.3 x64: PASSED

• importing passwords from Chrome 61.0.3163.100 into v0.19.28 rev: 08781a5 - PASSED
• importing passwords from Chromium 61.0.3163.79 into v0.19.28 rev: 08781a5 - PASSED

Once passwords were imported, ensured that the username and passwords fields were correctly being filled within Brave when visiting each website.

[tomasdev]

Not sure why this is closed, but I still cannot import my passwords from Chrome using a Google Account (different than Chrome Person 1, default)

Perhaps add a new import method to import from an exported CSV file (like Chrome does generate, columns are name,url,username,password)