Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

urlbar titlemode appends colon to the end of the hostname #9503

Closed
diracdeltas opened this issue Jun 15, 2017 · 2 comments
Closed

urlbar titlemode appends colon to the end of the hostname #9503

diracdeltas opened this issue Jun 15, 2017 · 2 comments
Assignees
@diracdeltas
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.18.x Release

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jun 15, 2017 •
edited by luixxiul
Loading

Test plan

  1. Open https://brave.com
  2. Disable "always show URL bar" mode
  3. Make sure colon is not appended to the hostname

instead of 'foo.com', it shows 'foo.com:'
@diracdeltas diracdeltas added this to the 0.18.x (Developer Channel) milestone Jun 15, 2017
@diracdeltas diracdeltas self-assigned this Jun 15, 2017
@NejcZdovc
Copy link
Contributor

Also adds ; | for about pages, for example preferences page

@diracdeltas
Copy link
Member Author

@NejcZdovc it's actually ':' not ';' i think. same underlying issue.

diracdeltas added a commit to brave/muon that referenced this issue Jun 15, 2017
@diracdeltas
Make muon.url.parse work more like Node's
d7d823b 
Fix brave/browser-laptop#9503
@diracdeltas diracdeltas mentioned this issue Jun 15, 2017
Merged
@diracdeltas diracdeltas mentioned this issue Jun 16, 2017
Closed
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.x Release
Development

No branches or pull requests
6 participants
@diracdeltas @alexwykoff @luixxiul @NejcZdovc @Jacalz @LaurenWags