Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Prevent Tab Close Button from allowing tab-tearoff #9511

Closed
bradleyrichter opened this issue Jun 16, 2017 · 0 comments · Fixed by #9692
Closed

Prevent Tab Close Button from allowing tab-tearoff #9511

bradleyrichter opened this issue Jun 16, 2017 · 0 comments · Fixed by #9692
Assignees
@cezaraugusto
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jun 16, 2017 •
edited by luixxiul
Loading

Test plan

#9692 (comment)

As a user, I may start to click a tab close button and then change my mind not to close it. I need to be able to mouse-out from the action while dragging as a means of escape/cancel.

Currently the drag results in a tear-off.
@bradleyrichter bradleyrichter added this to the 0.19.x (Nightly Channel) milestone Jun 16, 2017
cezaraugusto added a commit that referenced this issue Jun 23, 2017
@cezaraugusto
Prevent Tab Close Button from allowing tab-tearoff
410dd59 
Auditors: @luixxiul
Close #9511
@cezaraugusto cezaraugusto mentioned this issue Jun 23, 2017
Merged
cezaraugusto added a commit that referenced this issue Jun 24, 2017
@cezaraugusto
Prevent Tab Close Button from allowing tab-tearoff
1500ecd 
Auditors: @luixxiul
Close #9511
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2017
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging a pull request may close this issue.

Prevent Tab Close Button from allowing tab-tearoff brave/browser-laptop
5 participants
@luixxiul @cezaraugusto @bradleyrichter @srirambv @LaurenWags