Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix strange color of brave menu button when alert is displayed #9696

Closed
luixxiul opened this issue Jun 24, 2017 · 7 comments
Closed

Fix strange color of brave menu button when alert is displayed #9696

luixxiul opened this issue Jun 24, 2017 · 7 comments
Assignees
@luixxiul
Labels
bug design A design change, especially one which needs input from the design team. feature/navbar misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 24, 2017 •
edited
Loading

Test plan

#11415 (comment)

Describe the issue you encountered: Fix strange color of brave menu button when alert is displayed.

See: #9285 (comment)

  • Platform (Win7, 8, 10? macOS? Linux distro?): 0.16.9

  • Actual result:
    clipboard02

  • Expected result: instead of applying opacity, change the color to grey, with the counter.
    screenshot 2017-09-22 16 20 15
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. suggestion labels Jun 24, 2017
@luixxiul luixxiul mentioned this issue Jun 24, 2017
Closed
@alexwykoff
Copy link
Contributor

@luixxiul is this still a bug? What are the actual STR?

@bsclifton
Copy link
Member

@alexwykoff you can repro by running the following:
https://jsfiddle.net/6zj4sjxr/

I don't think it's a bug- I actually prefer how it looks (since grayed out looks like nothing is blocked). But I think it's a good one to talk about 😄

@bsclifton
Copy link
Member

cc: @bradleyrichter @jenn-rhim

@luixxiul
Copy link
Contributor Author

I felt it was weird as the counter block background color was not changed.

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Sep 17, 2017 via email

@bsclifton bsclifton mentioned this issue Sep 22, 2017
Closed
8 tasks
@luixxiul
Copy link
Contributor Author

The same opacity value applied to the disabled button will be applied to the counter block as well.

screenshot 2017-09-22 16 20 15

@luixxiul luixxiul self-assigned this Sep 23, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 24, 2017
@ghost ghost removed the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
@ghost ghost removed this from the 0.21.x (Nightly Channel) milestone Sep 26, 2017
@luixxiul luixxiul mentioned this issue Oct 10, 2017
Merged
8 tasks
@cezaraugusto cezaraugusto added this to the 0.22.x (Nightly Channel) milestone Oct 14, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@syuan100
Set the same opacity to the counter box as the disabled BrowserButton
1c75883 
Fixes brave#9696

Also:
- Update to the modified BEM style

Auditors: @cezaraugusto

Test Plan:
1. Open https://jsfiddle.net/6zj4sjxr/
2. Make sure both brave lion icon and the counter box has the same opacity
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jun 11, 2018
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified with macOS 10.12.6 using

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

This was referenced Jun 19, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
bug design A design change, especially one which needs input from the design team. feature/navbar misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
9 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @bradleyrichter @srirambv @LaurenWags @btlechowski