Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only primitives in BookmarksToolbar and BookmarkToolbarButton #9712

Closed
NejcZdovc opened this issue Jun 26, 2017 · 1 comment
Closed

Only primitives in BookmarksToolbar and BookmarkToolbarButton #9712

NejcZdovc opened this issue Jun 26, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 26, 2017 •
edited by luixxiul
Loading

Test plan

#9713 (comment)

Describe the issue you encountered:
Only primitives in merge props. Because of that we need to move context menu functions into the reducer.
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 26, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 26, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 26, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
d776d63 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 26, 2017
Merged
8 tasks
@bsclifton bsclifton mentioned this issue Jun 26, 2017
Closed
35 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 27, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
b1e8f14 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 28, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
83c5744 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 28, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
8aff1dc 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 28, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
081ddc8 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 30, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
d49b5ca 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 5, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
1466694 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 9, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
903ffd3 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 9, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
9439534 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 9, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
3fa0af0 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 10, 2017
@NejcZdovc
Removes all non-primitve types from BookmarksToolbar and BookmarkTool…
88f5188 
…barButton

Resolves brave#9712

Auditors: @bsclifton

Test Plan:
bbondy added a commit that referenced this issue Jul 10, 2017
@bbondy
Merge pull request #9713 from NejcZdovc/refactor/#9712-bookmarks
03ae74b 
Removes all non-primitive types from BookmarksToolbar and BookmarkTool…
bbondy added a commit that referenced this issue Jul 10, 2017
@bbondy
Merge pull request #9713 from NejcZdovc/refactor/#9712-bookmarks
1c1e3fa 
Removes all non-primitive types from BookmarksToolbar and BookmarkTool…
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Sep 20, 2017
Closed
@LaurenWags LaurenWags mentioned this issue Sep 20, 2017
Closed
@LaurenWags LaurenWags mentioned this issue Sep 20, 2017
Closed
@LaurenWags
Copy link
Member

@NejcZdovc in the test plan under '7 DND test' the second item (try to add a bookmark into a folder) is failing for me. It is logged here #11040 (comment)

This was referenced Sep 21, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
4 participants
@luixxiul @NejcZdovc @srirambv @LaurenWags