Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Downloading from Google Drive appears to become stuck #9810

Closed
alexwykoff opened this issue Jun 30, 2017 · 2 comments · Fixed by #9879
Closed

Downloading from Google Drive appears to become stuck #9810

alexwykoff opened this issue Jun 30, 2017 · 2 comments · Fixed by #9879
Assignees
@darkdh
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include webcompat
Milestone
0.19.x (Beta Chan...

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Jun 30, 2017 •
edited by luixxiul
Loading

Test Plan:

  1. Go to google drive
  2. Make sure block 3rd party cookies
  3. You should be able to download file eg. https://drive.google.com/file/d/0B_HAFnYs6Ur-VlRVMUIyamJLSHc/view (Debian virtualbox hard drive image via osboxes.org)

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    From a user in support :
    "Some feedback om Google Drive/Doc file downloads: When downloading content from the Drive, (e.g. MacOS native file types incl. .numbers .keynote) download gets stuck.

Process

  1. Google Drive Virus Scanning
  2. Mac OS Native Select Folder window where you choose the down location
  3. Bottom Download bar in Brave pops-up with the downloadable file notification in it saying "Downloading..." and it's stuck there.

On the other hand I have not issues with Safari here. Not sure if it's a write permission thing or something else. "

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    OS X

  • Brave Version (revision SHA):

  • Steps to reproduce:

    1. Attempt to download a file from Google Drive

  • Actual result:
    The download becomes frozen.

  • Expected result:
    The download should complete.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@alexwykoff alexwykoff added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Jun 30, 2017
@srirambv
Copy link
Collaborator

srirambv commented Jul 1, 2017

Need to set Allow all cookies for Google Drive to download any file. Blocking it causes the file name to show junk characters and doesn't complete download.

darkdh added a commit that referenced this issue Jul 5, 2017
@darkdh
Default disable 3rd party cookies for these sites
ac891d8 
(facebook, google drive)

fixes #698
fixes #9810

Auditors: @bsclifton, @bbondy

Test Plan:
1. Clear your session data
2. Open Brave
3. Go to facebook
4. The shield should show allow all cookies
5. You should be able to upload image to comment

1. Clear your session data
2. Open Brave
3. Go to Google drive
4. The shield should show allow all cookies
5. You should be able to download file

Respect users setting:
1. Make 3rd party cookie block on facebook/google drive
2. Upgrade Brave
3. Go to facebook/google drive
4. The shield should show block 3rd party cookies
@darkdh darkdh mentioned this issue Jul 5, 2017
Merged
8 tasks
@darkdh
Copy link
Member

darkdh commented Jul 5, 2017 •
edited
Loading

Test plan:

  1. Go to google drive
  2. Make sure block 3rd party cookies
  3. You should be able to download file

@darkdh darkdh self-assigned this Jul 5, 2017
@darkdh darkdh added webcompat and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Jul 5, 2017
@darkdh darkdh added this to the 0.19.x (Developer Channel) milestone Jul 5, 2017
darkdh added a commit that referenced this issue Jul 6, 2017
@darkdh
Add cookieException for google drive and referer exception for facebook
dc208c1 
fixes #698
fixes #9810

Auditors: @diracdeltas, @bsclifton, @bbondy

Test Plan:
1. Go to facebook
2. Make sure block 3rd party cookies
5. You should be able to upload image to comment

1. Go to google drive
2. Make sure block 3rd party cookies
3. You should be able to download file
darkdh added a commit that referenced this issue Jul 6, 2017
@darkdh
Add cookieException for google drive
3e1bc32 
fixes #9810

Auditors: @diracdeltas, @bsclifton, @bbondy

Test Plan:
1. Go to google drive
2. Make sure block 3rd party cookies
3. You should be able to download file
bsclifton pushed a commit that referenced this issue Jul 7, 2017
@darkdh @bsclifton
Add cookieException for google drive
d4165c9 
fixes #9810

Auditors: @diracdeltas, @bsclifton, @bbondy

Test Plan:
1. Go to google drive
2. Make sure block 3rd party cookies
3. You should be able to download file
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2017
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include webcompat
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging a pull request may close this issue.

Add cookieException for google drive brave/browser-laptop
6 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv @LaurenWags