Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Respect bookmark position when adding bookmarks #11178

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Respect bookmark position when adding bookmarks #11178

merged 1 commit into from
Sep 27, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 27, 2017

Fix #11177

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.19.x (Beta Channel) milestone Sep 27, 2017
@bbondy bbondy self-assigned this Sep 27, 2017
bsclifton
bsclifton approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 😄 👍 nice tests too

@bsclifton bsclifton merged commit ac97140 into 0.19.x Sep 27, 2017
@bsclifton bsclifton deleted the 11177 branch September 27, 2017 16:09
bsclifton added a commit that referenced this pull request Sep 27, 2017
@bsclifton
Merge pull request #11178 from brave/11177
8626edf 
 Respect bookmark position when adding bookmarks
@bsclifton
Copy link
Member

0.19.x ac97140
0.20.x 8626edf

bbondy added a commit that referenced this pull request Sep 27, 2017
@bbondy
Respect bookmark position when adding bookmarks
8e8a6f8 
Fix #11178

Auditors: @bsclifton
@bbondy
Copy link
Member Author

bbondy commented Sep 27, 2017

master: 8e8a6f8

syuan100 pushed a commit to syuan100/browser-laptop that referenced this pull request Nov 9, 2017
@bbondy @syuan100
Respect bookmark position when adding bookmarks
18e755f 
Fix brave#11178

Auditors: @bsclifton
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@bbondy bbondy

Labels
feature/bookmarks
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@bbondy @bsclifton @luixxiul