This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix displayed mixed content status #12743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
confirmed that the travis mixed content test fails on master (https://travis-ci.org/brave/browser-laptop/jobs/331029607#L6166) but passes with this PR |
darkdh
reviewed
Jan 22, 2018
| // partially-secure connection. It can only downgrade a secure | ||
| // connection. | ||
| isSecure = | ||
| e.securityInfo.mixedContentStatus === 'content-status-displayed' && this.props.isSecure !== false |
There was a problem hiding this comment.
do we need to handle content-status-displayed-and-ran which indicates both passive and active mixed content?
There was a problem hiding this comment.
never mind, I forgot we default block that active mixed content scripts so it won't reach that case
There was a problem hiding this comment.
yeah, i tried allowing insecure scripts on https://very.badssl.com/, but it only emitted content-status-displayed
darkdh
reviewed
Jan 22, 2018
| // partially-secure connection. It can only downgrade a secure | ||
| // connection. | ||
| isSecure = | ||
| e.securityInfo.mixedContentStatus === 'content-status-displayed' && this.props.isSecure !== false |
There was a problem hiding this comment.
never mind, I forgot we default block that active mixed content scripts so it won't reach that case
darkdh
approved these changes
Jan 22, 2018
darkdh
added a commit
that referenced
this pull request
Jan 22, 2018
Fix displayed mixed content status
darkdh
added a commit
that referenced
this pull request
Jan 22, 2018
Fix displayed mixed content status
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12742
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests