Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes issue #12918, hides empty ad container on www.yahoo.com #12964

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Fixes issue #12918, hides empty ad container on www.yahoo.com #12964

merged 1 commit into from
Feb 12, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jan 31, 2018

Fixes #12918

This is a pretty straightforward fix, the container for the yahoo billboard ad is identifiable by the element Id Billboard-ad. This adds that container to removeEmptyElements.css, as well as adds www.yahoo.com to the sites that removeEmptyElements.css is loaded on.

I did make a slight stylistic change, I broke out the sites inside the matches[] array on to a new line, as it was getting pretty lengthy on one line (it's presumably going to get longer). Let me know if this isn't preferred and I can revert it :)

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Navigate to https://www.yahoo.com/
  2. Confirm that the display on the billboard ad (identified by Id: Billboard-ad) is set to none.

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the 0.23.x (Nightly Channel) milestone Feb 8, 2018
@bsclifton
Copy link
Member

@jonathansampson can you review this when you get a chance? 😄

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ++

@ryanml
Copy link
Contributor Author

ryanml commented Feb 8, 2018

@jonathansampson @bsclifton awesome thanks guys :)

@bsclifton bsclifton merged commit 28c7db0 into brave:master Feb 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty Ad Containers on Yahoo!
2 participants