Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix untranslated recovery code text #13321

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fix untranslated recovery code text #13321

merged 1 commit into from
Feb 27, 2018

Conversation

srirambv
Copy link
Collaborator

Submitter Checklist:

Closes #13311

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Set browser language to any other apart from English US
  2. Enable payments -> Advance settings-> Backup codes
  3. Print recovery codes should open key in a new tab and should read Recovery Code
  4. Save recovery key and open in editor, should read Recovery Code

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@srirambv srirambv added this to the 0.21.x (Beta Channel) milestone Feb 27, 2018
@srirambv srirambv self-assigned this Feb 27, 2018
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thank you for a fast fix

@NejcZdovc NejcZdovc merged commit 5efdd96 into brave:master Feb 27, 2018
NejcZdovc added a commit that referenced this pull request Feb 27, 2018
Fix untranslated recovery code text
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 27, 2018

master 5efdd96
0.22 64a4cf3
0.21 3fec9f3

NejcZdovc added a commit that referenced this pull request Feb 27, 2018
Fix untranslated recovery code text
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants