Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Toggles siteInfoDialog on evCert click #14612

Closed
wants to merge 1 commit into from
Closed

Conversation

jonathansampson
Copy link
Collaborator

Fixes #14611

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Navigate to github.com
  2. Click GitHub, Inc. [US] in address bar.

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton
Copy link
Member

bsclifton commented Jul 2, 2018

Closing as this has already been fixed with #13164 (which has already been security reviewed) in 0.24.x

@bsclifton bsclifton closed this Jul 2, 2018
@bsclifton bsclifton deleted the issue-14611 branch July 2, 2018 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants