This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix the check for fullscreen window. #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auditors: @bbondy Test Plan: Press F11 and see if the div#window has class isFullScreen. The top bar should also be hidden in fullscreen mode.
|
just making sure, was this tested with both html full screen and per window full screen? |
|
++ |
This was referenced Sep 22, 2016
|
Sorry I had to revert this. |
This was referenced Sep 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors:
@bbondy @bridiver
Test Plan:
Press F11 and see if the div#window has class isFullScreen. The top bar should also be hidden in fullscreen mode.