This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
fix: nav button aspect ratio, closes #4355 #4356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #4355 |
|
This might be superseded by #4400. |
|
@liunkae might be not needed for this special design fix, but my suggestion still stands to deploy a simple set of 'standard css rules' that are a bit more tailored toward an electron app. |
|
closed in favour of #4519 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the button aspect ratio issue by setting a global
box-sizing: border-box;
which is a pretty invasive step but will save us from major design headaches in the future as the box model becomes much simpler.
https://www.paulirish.com/2012/box-sizing-border-box-ftw/