Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixing bookmarks toolbar "hover after click" behavior on folders #4361

Merged
merged 3 commits into from
Oct 10, 2016
Merged

Fixing bookmarks toolbar "hover after click" behavior on folders #4361

merged 3 commits into from
Oct 10, 2016

Commits on Oct 7, 2016

  1. Fixing bookmarks toolbar "hover after click" behavior on folders 

    When context menu is expanded for a bookmark folder, mousing over other folders will auto-expand them (closing your previous folder's context menu).
Matching behavior in Chrome, mousing over non-folders will hide the menu.

Fixes #1725

Also includes:
- Added constant to faviconUtils for default icon size (referenced from bookmarksToolbar component)
- Moved bookmarksToolbar component and faviconUtils to new directory structure

Auditors: @bbondy @darkdh

Test Plan:
1. Launch Brave and ensure you have bookmarks toolbar showing with at least 2 folders and 1 non-folder
2. Click one of the folders in bookmarks toolbar and confirm it opens
3. Mouse over the other folder and confirm it auto-expands the menu
4. Mouse over a non-folder (ex: a bookmark) and confirm it hides the menu
5. Mouse back over a folder and confirm it auto-expands it again
6. Click anywhere to dismiss the context menu
    @bsclifton
    bsclifton committed Oct 7, 2016
    Configuration menu
    Copy the full SHA
    1ede4e9 View commit details
    Browse the repository at this point in the history

  2. - Added new bookmarksToolbars test file with tests for existing and n… 

    …ew functionality

- Some cleanup, per comments, cc: @bridiver
    @bsclifton
    bsclifton committed Oct 7, 2016
    Configuration menu
    Copy the full SHA
    39c7c80 View commit details
    Browse the repository at this point in the history

  3. Cleanup part duex, per conversation w/ @bridiver :) 

    Auditors: @bridiver
    @bsclifton
    bsclifton committed Oct 7, 2016
    Configuration menu
    Copy the full SHA
    6f0336a View commit details
    Browse the repository at this point in the history