Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update menu.js to rebuild when handling (add/remove) bookmark folders #4390

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Update menu.js to rebuild when handling (add/remove) bookmark folders #4390

merged 1 commit into from
Oct 4, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Sep 29, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Update menu.js to also rebuild when handling (add/remove) bookmark folders

Fixes #4227

Auditors: @bridiver

Test Plan:

  1. Launch Brave and ensure bookmarks toolbar is showing
  2. Right click toolbar, choose Add Folder
  3. Specify the name "1234" and hit save
  4. Ensure "Bookmarks" menu is updated after saving
  5. Save a bookmark inside of this folder
  6. Verify "Bookmarks" menu looks correct

@bsclifton bsclifton added this to the 0.12.4dev milestone Sep 29, 2016
@bridiver
Copy link
Collaborator

looks good, but is there a test for it?

@bsclifton
Copy link
Member Author

@bridiver there are webdriver tests for bookmarking- but not for adding a bookmark folder. I did look into this and unfortunately, we have electron popping up a system popup menu (versus our custom context menu, which we could test).

I tried simulating key presses but was unable to get it working. When I mentioned trying the keypress approach, the twitter acct for WebDriverIO said it's not possible. We could add an IPC shortcut or other mechanism for adding a folder but even then, I don't think system menus are testable (I would love to be wrong on this one)

@bridiver
Copy link
Collaborator

I think we have some other tests where we trigger the action directly

@bridiver
Copy link
Collaborator

see the pinned tab test and a few others

@bsclifton
Copy link
Member Author

@bridiver tests added! thanks for calling out the missing tests and giving an example to check out 😄

…folders

Added tests which ensure menu gets rebuild when adding bookmark or bookmark folder

Fixes #4227
Fixes #3968

Auditors: @bridiver

Test Plan:
1) Launch Brave and ensure bookmarks toolbar is showing
2) Right click toolbar, choose Add Folder
3) Specify the name "1234" and hit save
4) Ensure "Bookmarks" menu is updated after saving
5) Save a bookmark inside of this folder
6) Verify "Bookmarks" menu looks correct

Auditors: @bridiver
@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

++

@srirambv
Copy link
Collaborator

srirambv commented Oct 5, 2016

Steps outlined works but not the expected behavior. Issue #4538 raised for the same

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants