This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Crash reporting toggle renderer #4606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add toggle in advanced preferences to enable or disable crash reporting * Enable crash reporting on startup if preferences selected Auditors: @bbondy Test Plan: * Navigate to Preferences > Advanced * Toggle crash reporting to off (restart browser) * Load browser and select crash from debug menu -> Confirm crash report NOT sent to stats.brave.com * Load browser and navigate to Preferences > Advanced * Toggle crash reporting to on (restart browser) * Load browser and select crash from debug menu -> Confirm crash report SENT to stats.brave.com
* Enable crash reporting on undefined or true value in setting * Update state documentation Auditors: @bbondy Test Plan: In previous commit
* Add toggle in advanced preferences to enable or disable crash reporting * Enable crash reporting on startup if preferences selected Auditors: @bbondy Test Plan: * Navigate to Preferences > Advanced * Toggle crash reporting to off (restart browser) * Load browser and select crash from debug menu -> Confirm crash report NOT sent to stats.brave.com * Load browser and navigate to Preferences > Advanced * Toggle crash reporting to on (restart browser) * Load browser and select crash from debug menu -> Confirm crash report SENT to stats.brave.com
* Enable crash reporting on undefined or true value in setting * Update state documentation Auditors: @bbondy Test Plan: In previous commit
…top into crash-reporting-toggle
bbondy
reviewed
Oct 10, 2016
| // Setup the crash handling for mac renderer processes | ||
| // https://github.com/electron/electron/blob/master/docs/api/crash-reporter.md#crashreporterstartoptions | ||
| console.log('macOS renderer crash reporting initialized') | ||
| require('../app/crash-herald').init() |
There was a problem hiding this comment.
This file should probably go in app/common/crash-herald, but that doesn't block this review.
|
++ |
This was referenced Oct 12, 2016
This was referenced Oct 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add crash reporting toggle to advanced preferences
This handles main process crashes and renderer crashes on osx
Fixes: #4479
Test Plan:
-> Confirm crash report NOT sent to stats.brave.com
-> Confirm crash report SENT to stats.brave.com