This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Update Windows titlebar code to ignore AltGr #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
reviewed
Oct 10, 2016
| @@ -0,0 +1,14 @@ | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
nit: remove newlines from start of file
bbondy
reviewed
Oct 10, 2016
| * License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
| * You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| const KeyLocationCodes = { |
There was a problem hiding this comment.
nit2: Name it the same you call variables you require to for better grep-ability, so keyLocations
bbondy
reviewed
Oct 10, 2016
| @@ -131,6 +132,11 @@ class Main extends ImmutableComponent { | |||
| const customTitlebar = this.customTitlebar | |||
| switch (e.which) { | |||
| case keyCodes.ALT: | |||
| // Ignore right alt (AltGr) | |||
| if (e.location === keyLocations.DOM_KEY_LOCATION_RIGHT) { | |||
There was a problem hiding this comment.
neat I didn't even know this existed.
|
A few nits, but after that I don't need to see this again so just merge directly to master. |
This was referenced Oct 12, 2016
This was referenced Oct 14, 2016
This was referenced Oct 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Update Windows titlebar code to ignore AltGr
Fixes #4626
Auditors: @bbondy
Test plan