Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tabs fine tuning #4829

Merged
merged 3 commits into from
Oct 18, 2016
Merged

Tabs fine tuning #4829

merged 3 commits into from
Oct 18, 2016

Conversation

bradleyrichter
Copy link
Contributor

Test Plan:

Confirm styling and alignments changes are OK on windows 7, 8, 10.

image

@bradleyrichter bradleyrichter added this to the 0.12.5dev milestone Oct 16, 2016
@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Oct 16, 2016
@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.5dev Oct 16, 2016
@bsclifton
Copy link
Member

Here's a shot from Windows 10
image

@bsclifton
Copy link
Member

Windows 7 at 150% DPI
image

@bsclifton
Copy link
Member

And lastly, here's Windows 8. Looks and feels consistent across the board 😄
image

@bradleyrichter
Copy link
Contributor Author

@bsclifton thanks for the check...

It looks like the lock icon is moving up, and appears to be larger. Do you have a separate windows adjustment for it?

@bsclifton
Copy link
Member

bsclifton commented Oct 16, 2016

@bradleyrichter I don't see any Windows specific styles being applied. Lock shows as 16px (it's the FontAwesome face w/ class "fa-lock")

Here's a closer up shot. It does seem the URL could be centered better
image

@bsclifton
Copy link
Member

bsclifton commented Oct 16, 2016

Here's where the margin comes from (on Windows) that pushes the text in the input down:

margin: 2px 0 0 3px;

Setting it to have 0 margin on top seems to fix the issue (although, I suspect it may break Mac):
image

@bsclifton
Copy link
Member

bsclifton commented Oct 17, 2016

@bradleyrichter if you want to resolve the conflict, I think this is good for merge 😄

The issue I pointed out above is already captured with #4814

@bbondy
Copy link
Member

bbondy commented Oct 22, 2016

Part of this was reverted here:
1e0d74c

For regressions described here:
#5005

Please post a follow up labeled with release/non blocking to track, i can be tracked in 0.12.6 for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants