Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix Brave crash on confirm bug #4887

Closed
wants to merge 1 commit into from
Closed

fix Brave crash on confirm bug #4887

wants to merge 1 commit into from

Conversation

willy-b
Copy link
Contributor

@willy-b willy-b commented Oct 18, 2016

for your consideration, just one way to fix this

Test Plan:

  1. Open Brave
  2. Visit http://pentesting.x10host.com (entire page content is: <script>confirm(1)</script>)
  3. Observe that Brave does not crash, and confirm dialog with message content "1" is displayed.

Fix:

  • dialog.showMessageBox requires that the message and title arguments are strings
  • if they are numbers instead, they're now coerced to strings before passing them to showMessageBox

- `dialog.showMessageBox` requires that the message and title arguments are strings
- if they are numbers instead, they are now coerced to strings before passing them to `showMessageBox`

fixes #4883
@luixxiul luixxiul added the crash label Oct 18, 2016
@willy-b
Copy link
Contributor Author

willy-b commented Oct 18, 2016

(realized this can be solved by doing exactly what @bridiver did in #4798, so closing in favor of new PR, whoops.)

@willy-b willy-b closed this Oct 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants