Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Caption buttons are no longer tab focusable #4902

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Caption buttons are no longer tab focusable #4902

merged 1 commit into from
Oct 18, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #4846

Auditors: @bbondy

Test plan:

  1. Launch Brave on Windows and set focus to URL bar
  2. Press tab to move focus and hit enter
  3. Window should not minimize, maximize, or close (focus should have went
    to the page)

Fixes #4846

Auditors: @bbondy

Test plan:
1. Launch Brave on Windows and set focus to URL bar
2. Press tab to move focus and hit enter
3. Window should not minimize, maximize, or close (focus should have went
to the page)
@bbondy
Copy link
Member

bbondy commented Oct 18, 2016

object destructuring ftw

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing Tab, then Enter in URL bar unexpectedly minimizes window on Windows
3 participants