Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL input field on the bookmark pulldown disappears #4927

Merged
merged 1 commit into from
Oct 19, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Oct 18, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4897

Auditors @luixxiul @bbondy

Test Plan:

To test, make sure that after clicking the star in the URLbar (both on a currently bookmarked and currently not bookmarked page) you can edit both the name and location without the form changing (i.e the location field disappearing)

@jkup jkup added this to the 0.12.6dev milestone Oct 18, 2016
@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

++ thanks!

@bbondy bbondy merged commit fc14b2e into master Oct 19, 2016
@luixxiul
Copy link
Contributor

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants