Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Improve UX of default browser check and Manage Adblock Setting button #4951

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Improve UX of default browser check and Manage Adblock Setting button #4951

merged 1 commit into from
Oct 19, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 19, 2016 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #4935

Auditors: @bbondy

Test Plan: N/A

Screen shots

screen shot 2016-10-19 at 10 27 37
screen shot 2016-10-19 at 10 31 38

screen shot 2016-10-19 at 10 27 57

@darkdh darkdh added this to the 0.12.6dev milestone Oct 19, 2016
@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

++

@bbondy bbondy merged commit 7baec37 into brave:master Oct 19, 2016
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. settings labels Oct 19, 2016
This was referenced Oct 20, 2016
Closed
Closed
@alexwykoff alexwykoff mentioned this pull request Oct 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win64 settings
Projects
None yet
Milestone
0.12.6dev
Development

Successfully merging this pull request may close these issues.

Always check on startup option is too glued to the set as default... button
5 participants
@darkdh @bbondy @alexwykoff @luixxiul @srirambv