This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix default setting behavior for getSetting() #4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I accidently introduced the bug here (merged into 0.12.6): 889757e#commitcomment-19471078 The fix by @darkdh is correct, except password manager defaults to a null value (not undefined) 1092758 This fix checks against undefined and null Auditors: @darkdh @bbondy Test Plan: run unit tests (most PW manager ones were failing)
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidently introduced the bug here (merged into 0.12.6):
889757e#commitcomment-19471078
The fix by @darkdh is correct, except password manager defaults to a null value (rather than undefined)
1092758
This fix checks against both undefined and null
Auditors: @darkdh @bbondy
Test Plan: run unit tests (most PW manager ones were failing)