This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Disable option to add a bookmark without location and a folder without a title. #5034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a folder without a title. Fix #5010 Auditors: @bsclifton Test Plan: 1) Add a bookmark 2) Edit bookmark removing its location 3) "Done" button should be disabled and: 1) Add a bookmark folder 2) Remove folder's title 3) "Done" button should be disabled
bsclifton
reviewed
Oct 21, 2016
| pointer-events: none; | ||
| // prevent titleMode animation from overriding opacity |
There was a problem hiding this comment.
@cezaraugusto was this file intentionally added?
There was a problem hiding this comment.
yes, our disabled buttons have a small opacity and titleMode's fadeIn animation overrides it.
If not set this way, disabled buttons still look enabled for users.
This was referenced Oct 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5010
Auditors: @bsclifton
Test Plan:
and: