This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add missing location to "new bookmark" button on about:bookmarks #5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update heading on Add/Edit bookmark control to be aware of all add/edit scenarios - location now included on new bookmark (from about:bookmarks) - cleanup on aboutActions Fixes #5031 Auditors: @jkup @cezaraugusto Test Plan: 1. Launch Brave and go to about:bookmarks 2. Click the Star+ icon (on the top right area of screen, above bookmarks in column header) 3. Notice control now says "Create New Bookmark" and includes location :)
This was referenced Oct 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Add missing location to "new bookmark" button on about:bookmarks
Fixes #5031
Auditors: @jkup @cezaraugusto
Test Plan: