Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Insert virtual history items for sites like www.google.ca in auto-suggestion url #5278

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

aekeus
Copy link
Member

@aekeus aekeus commented Oct 30, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

When a site is visted for a deep linked page or with parameters
the history item is stored with the complete parameters and links.
Often after a user visits the site a number of times, the expectation
shifts such that the simple domain should be the first suggestion
in the url bar suggestion list. The canonical example is when a
user searches Google a number of times via the url bar. After three
searches www.google.com will be added as a virtual history item in the
search results.

Auditors: @bbondy, @BradRichter

Test Plan:

  1. Clear history
  2. End three searchs from the url bar without accessing www.google.com
  3. Open a new tab and type goog - ensure a history item for www.google.com is displayed

Fixes: #5067

When a site is visted for a deep linked page or with parameters
the history item is stored with the complete parameters and links.
Often after a user visits the site a number of times, the expectation
shifts such that the simple domain should be the first suggestion
in the url bar suggestion list. The canonical example is when a
user searches Google a number of times via the url bar. After three
searches www.google.com will be added as a virtual history item in the
search results.

Auditors: @bbondy, @BradRichter

Test Plan:

  1. Clear history
  2. End three searchs from the url bar without accessing www.google.com
  3. Open a new tab and type goog - ensure a history item for www.google.com is displayed

Fixes: #5067
@aekeus aekeus added this to the 0.12.8dev milestone Oct 30, 2016
@aekeus aekeus self-assigned this Oct 30, 2016
@bbondy
Copy link
Member

bbondy commented Oct 31, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants