This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Allow editing location on Add Bookmark in bookmark toolbar #5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave#5374 Auditors: @bsclifton Test Plan: 1. Right click on bookmark toolbar 2. Select Add Bookmark 3. Should be able to edit the location
|
LGTM! Good catch and easy fix 😄 |
|
For folks following along at home, here's what got updated 😄 (what got updated being the code executing when you choose the "Add Folder..." option) |
|
++ |
This was referenced Nov 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).fix #5374
Auditors: @bsclifton
Test Plan: